Update ExperimentManager interface and implement plugin methods for StandardExperimentManager #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR is a continuation of #143, where we introduced the general structure for RPC-based experiment engine plugins. This PR updates ExperimentManager interface definition to make it compatible with the plugin implementation and extends RPC plugin (client/server) to support methods of the
StandardExperimentManager
interface.Changes:
ValidateExperimentConfig
/GetExperimentRunnerConfig
methods now standardized and moved underExperimentManager
. Previously, signatures of these methods were different forStandardExperimentManager
andCustomExperimentManager
, which was tricky to support in RPC plugin, because rpcClient should implement methods of both standard/custom ExperimentManager (to support communication with both types).StandardExperimentManager
interface